Add euiMessageMgr.h

[Amethyst-szs]

eui::MessageMgr.h

An implementing source file has not been created, however merging this is still important so that it can be pulled into the MonsterDruide1/OdysseyHeaders repository as a submodule.

This header has become particularly important due to Amethyst-szs/MoonFlow's upcoming exefs extension feature requiring a code patch that utilizes this header, and that feature will be waiting until this header is committed upstream into the OdysseyDecomp.

---

This change is 

[MonsterDruide1]

Great to see that OdysseyHeaders is picking up on usage in modding workflows, thanks for going the route through contributing here instead of adding custom workarounds!

@MonsterDruide1 reviewed 1 file and all commit messages, and made 8 comments.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on Amethyst-szs).

---

a discussion (no related file):
clang-format fails

---

include/euiMessageMgr.h line 22 at r1 (raw file):

public:
    virtual void loadArchive(sead::Heap*, void*, unsigned int);

Suggestion:

u32

---

include/euiMessageMgr.h line 23 at r1 (raw file):

public:
    virtual void loadArchive(sead::Heap*, void*, unsigned int);
    virtual void unloadArchive(void*);

Suggestion:

class MessageMgr {
    SEAD_RTTI_BASE(MessageMgr);
    SEAD_SINGLETON_DISPOSER(MessageMgr);

public:
    class Archive;

    MessageMgr();
    virtual ~MessageMgr();
    
    virtual void loadArchive(sead::Heap*, void*, unsigned int);
    virtual void unloadArchive(void*);

---

include/euiMessageMgr.h line 25 at r1 (raw file):

    virtual void unloadArchive(void*);

    void initialize(sead::Heap*, unsigned int maxColors);

Suggestion:

void initialize(sead::Heap*, u32 maxColors);

---

include/euiMessageMgr.h line 31 at r1 (raw file):

    void dumpLastGotMessageSetInfo(); // Implementation requires some debug compiler flag

    void setGradationColor(unsigned int idx, sead::Color4u8 top, sead::Color4u8 bottom);

Suggestion:

void setGradationColor(u32 idx, sead::Color4u8 top, sead::Color4u8 bottom);

---

include/euiMessageMgr.h line 35 at r1 (raw file):

    
    MessageSet* getLayoutMessageSet(sead::SafeString const&) const;
    MessageSet* getMessageSet(sead::SafeString const&) const;

Suggestion:

    MessageSet* getLayoutMessageSet(const sead::SafeString&) const;
    MessageSet* getMessageSet(const sead::SafeString&) const;

---

include/euiMessageMgr.h line 35 at r1 (raw file):

    
    MessageSet* getLayoutMessageSet(sead::SafeString const&) const;
    MessageSet* getMessageSet(sead::SafeString const&) const;

• reordered
• removed comment (only important in its implementation)
• functions ending in _ are usually protected or even private

Suggestion:

    MessageSet* getLayoutMessageSet(sead::SafeString const&) const;
    MessageSet* getMessageSet(sead::SafeString const&) const;

    void setGradationColor(unsigned int idx, sead::Color4u8 top, sead::Color4u8 bottom);
    void setTextBoxWidthSizeOverColor(sead::Color4u8);

    void dumpLastGotMessageSetInfo();

protected:
    void archiveDisposeCallback_(Archive*);

[Amethyst-szs]

That should be the clang-format issue and reformatting completed, do let me know if there's any remaining issues.

@Amethyst-szs made 8 comments.
Reviewable status: 0 of 1 files reviewed, 7 unresolved discussions (waiting on MonsterDruide1).

---

a discussion (no related file):

Previously, MonsterDruide1 wrote…

clang-format fails

Done

---

include/euiMessageMgr.h line 35 at r1 (raw file):

Previously, MonsterDruide1 wrote…

• reordered
• removed comment (only important in its implementation)
• functions ending in _ are usually protected or even private

Done

---

include/euiMessageMgr.h line 22 at r1 (raw file):

public:
    virtual void loadArchive(sead::Heap*, void*, unsigned int);

Done

---

include/euiMessageMgr.h line 23 at r1 (raw file):

public:
    virtual void loadArchive(sead::Heap*, void*, unsigned int);
    virtual void unloadArchive(void*);

Done

---

include/euiMessageMgr.h line 25 at r1 (raw file):

    virtual void unloadArchive(void*);

    void initialize(sead::Heap*, unsigned int maxColors);

Done

---

include/euiMessageMgr.h line 31 at r1 (raw file):

    void dumpLastGotMessageSetInfo(); // Implementation requires some debug compiler flag

    void setGradationColor(unsigned int idx, sead::Color4u8 top, sead::Color4u8 bottom);

Done

---

include/euiMessageMgr.h line 35 at r1 (raw file):

    
    MessageSet* getLayoutMessageSet(sead::SafeString const&) const;
    MessageSet* getMessageSet(sead::SafeString const&) const;

Done

[MonsterDruide1]

@MonsterDruide1 reviewed 1 file and all commit messages, made 1 comment, and resolved 6 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Amethyst-szs).

---

a discussion (no related file):

Previously, Amethyst-szs (Amethyst-szs) wrote…

Done

New issues appeared 🙃

[Amethyst-szs]

@Amethyst-szs made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on MonsterDruide1).

---

a discussion (no related file):

Previously, MonsterDruide1 wrote…

New issues appeared 🙃

Done, gotta love those two tabs that just decided they didn't want to go 🙃

[MonsterDruide1]

@MonsterDruide1 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Amethyst-szs).

[Amethyst-szs]

@Amethyst-szs made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Amethyst-szs).