Fixes scala-reflect issue with GitHub pureconfig (https://github.com/opalj/JCG/issues/17)

[svenkeidel]

Hi,

This fixes opalj/JCG#17.

The issue is that Opal depends on scala-reflect, which is binary incompatible with Scala 3 classes.
The problem is that Githubs pureconfig generates Scala 3 code that crashes scala-reflect searches for ConfigurationEntryPointsFinder.

The fix reimplements the ConfigurationEntryPointsFinder.EntryPointContainer configuration reader to avoid the generation of problematic Scala 3 classes.

I tested the fix in JCG and it works.

Sven

[errt]

/it:test

[errt]

Why this? There should only be one way to write the keys that is valid now.

[svenkeidel]

• reference.conf uses "declaring-class":
  

  opal/OPAL/br/src/main/resources/reference.conf

  Lines 96 to 111 in 55085cf

  	{declaring-class = "java/lang/System", name = "initializeSystemClass", descriptor = "()V"},
  	{declaring-class = "java/lang/Thread", name = "<init>", descriptor = "(Ljava/lang/ThreadGroup;Ljava/lang/Runnable;)V"},
  	{declaring-class = "java/lang/Thread", name = "<init>", descriptor = "(Ljava/lang/ThreadGroup;Ljava/lang/String;)V"},
  	{declaring-class = "java/lang/ThreadGroup", name = "<init>", descriptor = "()V"},
  	{declaring-class = "java/lang/Thread", name = "exit", descriptor = "()V"},
  	{declaring-class = "java/lang/ThreadGroup", name = "uncaughtException", descriptor = "(Ljava/lang/Thread;Ljava/lang/Throwable;)V"},
  	{declaring-class = "java/lang/ref/Reference$ReferenceHandler", name = "run", descriptor = "()V"},
  	{declaring-class = "java/lang/ClassLoader", name = " <init>", descriptor = "()V"},
  	{declaring-class = "java/lang/ClassLoader", name = "loadClassInternal", descriptor = "(Ljava/lang/String;)Ljava/lang/Class;"},
  	{declaring-class = "java/lang/ClassLoader", name = "checkPackageAccess", descriptor = "(Ljava/lang/Class;Ljava/security/ProtectionDomain;)V"},
  	{declaring-class = "java/lang/ClassLoader", name = "addClass", descriptor = "(Ljava/lang/Class;)V"},
  	{declaring-class = "java/lang/ClassLoader", name = "findNative", descriptor = "(Ljava/lang/ClassLoader;Ljava/lang/String;)J"},
  	{declaring-class = "java/security/PrivilegedActionException", name = "<init>", descriptor = "(Ljava/lang/Exception;)V"},
  	{declaring-class = "java/lang/System", name = "initPhase1", descriptor = "()V"},
  	{declaring-class = "java/lang/System", name = "initPhase2", descriptor = "(ZZ)I"}
  	{declaring-class = "java/lang/System", name = "initPhase3", descriptor = "()V"}

• org.opalj.br.analyses.cg.InitialEntryPointsKey.entryPoints uses "declaringClass": https://github.com/opalj/JCG/blob/master/jcg_opal_testadapter/src/main/scala/OpalJCGAdatper.scala#L82-L83

[errt]

The latter is because JCG has not been updated to recent Scala-3 based OPAL which, due to changes in the config library, had to change to "declaring-class". I.e., I think JCG has to be changed here instead of supporting different keys in OPAL.

[svenkeidel]

Documentation uses "declaringClass" too:

opal/OPAL/br/src/main/scala/org/opalj/br/analyses/cg/EntryPointFinder.scala

Lines 233 to 243 in 55085cf

	* {{{
	* org.opalj.br.analyses.cg {
	* InitialEntryPointKey {
	* analysis = "org.opalj.br.analyses.cg.ConfigurationEntryPointsFinder"
	* entryPoints = [
	* {declaringClass = "java/util/List+", name = "add"},
	* {declaringClass = "java/util/List", name = "remove", descriptor = "(I)Z"}
	* ]
	* }
	* }
	* }}}

Probably should be updated as well.

[errt]

Absolutely. Want to do that in this PR?

[svenkeidel]

Done.

[errt]

LGTM