Add support for [email protected], update example using webpack - #25
Open
jaxrtech wants to merge 4 commits into
Open
Add support for [email protected], update example using webpack#25jaxrtech wants to merge 4 commits into
jaxrtech wants to merge 4 commits into
Conversation
Contributor
|
I'm no longer belongs to Oozou company anymore. I think you could asked this guy @dynjo to have someone from the company to maintain it. Personally, I still want to continue contribute to this repo too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the plugin for support with [email protected]. The example also works again as I've setup Webpack to properly bundle the plugin with the example.
I don't know if this was a previous bug, but the input is always a keystoke behind since the callback is invoked
onKeyDownwhich is not going to have yet appended the next character from the keystoke. This will have to be separately fixed (?).Sidenote: This is the same PR I've submitted to one of the forked repos and likewise not all these commits are mine per se but brings the plugin to a current working state
(see also XuHaoJun#1)