Regenerate proto bindings with ProtoBuf.jl 1.3#127
Merged
Conversation
Removes the "older version of ProtoBuf.jl ... was deprecated" warning emitted when loading the package on ProtoBuf 1.3+. Adds a compat shim in OpenTelemetryProto.jl: ProtoBuf 1.3 widened `message_done(d)` to `message_done(d, endpos, group)`. On older ProtoBuf the 3-arg form is defined as a delegate to the 1-arg one (OTLP is proto3 so endpos/group are unused). Uses `hasmethod` feature detection so the existing `ProtoBuf = "1"` compat range keeps working. Public API (struct names, fields, exports) is preserved via const aliases generated for the new ##Stub# parametric types. Fixes oolong-dev#123 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Covers scalar/array/kvlist AnyValue, nested ExportTraceServiceRequest and ExportLogsServiceRequest, and the unknown-field skip path that exercises the regenerated decoders' `Base.skip` call site. Verified passing on ProtoBuf 1.0.16, 1.2.2 and 1.3.0. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Adds an ExportMetricsServiceRequest roundtrip with Sum (with attributes, AGGREGATION_TEMPORALITY_CUMULATIVE, is_monotonic), Histogram (count, sum, bucket_counts, explicit_bounds, min/max) and Gauge (as_double). Exercises the largest schema in the OTLP set. Verified 66/66 on ProtoBuf 1.0.16, 1.2.2 and 1.3.0. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_pb.jlfiles insrc/protowith ProtoBuf.jl 1.3 codegen, removing theolder version of ProtoBuf.jl ... was deprecatedwarning.OpenTelemetryProto.jlso the package still loads against the fullProtoBuf = "1"compat range. ProtoBuf 1.3 widenedmessage_done(d)intomessage_done(d, endpos, group); on older ProtoBuf the 3-arg form is defined as a delegate to the 1-arg one. Useshasmethodfeature detection rather than a version check.const Foo = var"##Stub#Foo"{...}aliases.Also bumps
OpenTelemetryProtofrom0.20.0to0.20.1and addsCodecZlib/Downloads/Tartosrc/proto/dev/Project.toml(already imported bygen.jl).Fixes #123
Test plan
OpenTelemetryProtoagainst ProtoBuf 1.3.0 — no deprecation warning, roundtrip encode/decode of a nestedExportTraceServiceRequestsucceeds.OpenTelemetryProtoagainst ProtoBuf 1.2.2 — shim engages, same roundtrip succeeds.🤖 Generated with Claude Code