feat(ui): add responsive hamburger navbar for mobile devices#25
Merged
Conversation
The navigation bar had no mobile adaptation — on screens narrower than 768px, the nav links and auth buttons overflowed the viewport, causing a broken horizontal-scroll experience. Changes: - Add .hamburger button (3-bar icon) visible only on mobile (≤768px) - Nav slides in/out below the header when hamburger is toggled - Hamburger animates into an X when menu is open (CSS transform) - Proper ARIA attributes: aria-expanded, aria-controls, aria-label - Escape key closes the menu and returns focus to the toggle button - Nav links close the menu automatically on click - Fix Windows-only backslash paths (log\login.html → log/login.html) which fail on Linux/macOS servers and GitHub Pages - Add semantic <main> wrapper and role attributes for accessibility - Add explicit width/height on hero image to reduce Cumulative Layout Shift
|
@KGFCH2 is attempting to deploy a commit to the Om Roy's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
i don't accept your pr you directly do pr without assigning the issue to you |
Contributor
Author
|
Resolved... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #24
Summary
Adds a fully accessible hamburger menu for mobile viewports. The nav collapses below 768px, triggered by an animated 3-bar → X toggle button with complete keyboard support.
Changes Made
.hamburgerbutton (CSS 3-bar animated to X when open)#navMenuhidden on mobile, revealed via.is-openclassaria-expanded,aria-controls,aria-labelon hamburger buttonlog\login.html→log/login.html)<main>semantic wrapper and ARIA roles toindex.htmlwidth/heighton hero image (reduces CLS)Testing
Screenshots
Checklist