refactor pipeline, expand tests, rewrite docs#3
Open
nz wants to merge 3 commits into
Open
Conversation
nz
force-pushed
the
nz/pipeline-refactor-and-docs
branch
from
July 14, 2026 16:57
3277fca to
a5f4e7b
Compare
6 tasks
Runs `nix flake check` on ubuntu-latest for every push to main and every pull request. Uses DeterminateSystems' nix-installer plus magic-nix-cache so incremental reruns don't rebuild every gem from source. x86_64-linux only for now; darwin/aarch64 coverage can be layered on later without changing this workflow's shape.
Renames parser-helpers/filter-helpers to parse/resolve, extracts nokogiri config into gem-configs.nix, adds transitive dep expansion so build-time gems survive filtering, and adds a nix-support/setup-hook that exports GEM_PATH so downstream flakes get it automatically via buildInputs. Adds pipeline-logic tests (555 lines), lockfile fixtures, and a platform-gems integration check wired into flake.checks. Rewrites Readme, adds ARCHITECTURE.md and CONTRIBUTING.md, retires TESTING.md (content folded into the two new docs).
nz
force-pushed
the
nz/pipeline-refactor-and-docs
branch
from
July 14, 2026 17:26
a5f4e7b to
13ebc91
Compare
robsears
previously approved these changes
Jul 14, 2026
ASCII box-drawing renders inconsistently across viewers and can't be rewritten by tools; the mermaid version is native on GitHub and edits cleanly. File map stays plain text — mermaid doesn't have a good idiom for a directory tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser-helpers/filter-helperstoparse/resolve; extract nokogiri intogem-configs.nix; add transitive-dep expansion so build-time gems (e.g.mini_portile2) survive filtering; addwarnIfNoPlatformGemsfor lockfiles missing precompiled variants.gemfileEnvoutput now writesnix-support/setup-hookexportingGEM_PATH, so consumers get gems via standardbuildInputspropagation instead of settingGEM_PATHmanually. Also fixes a latentruby ? rubyself-recursion.test-pipeline-logic.nix(555 lines), lockfile fixtures undertest/fixtures/lockfiles/, and aplatform-gemsintegration check wired intoflake.checks.ARCHITECTURE.mdandCONTRIBUTING.md, retiresTESTING.md(folded in).Test plan
nix flake checkpasses (unit + integration on aarch64-darwin)nixfmt --checkclean acrosslib/,test/,flake.nixexport GEM_PATH)aarch64-linux/x86_64-linux) in CI