fix: update notice + skill name prefix#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bug fixes in one PR.
1. Update notice now actually shows
The old code used
Promise.racewith a 500ms window after the command — fast commands (version,status,--help) exited before the npm registry responded, so no one ever saw the update banner.New pattern: write-on-check, show-on-next-run (same as npm/Homebrew):
showPendingUpdateNotice()reads a notice file at process start, prints the banner, deletes the filescheduleUpdateCheck()fires a background fetch with no await, writes the notice file if newer version found2. Skill name prefix to avoid conflicts
Skill
name:fields in SKILL.md were bare (search,scrape, etc.) — when two skill providers are installed, the agent sees name collisions. Updated all 13 toolostep-search,olostep-scrape, etc. The install filter normalizes both sides so--skill searchand--skill olostep-searchboth still work.Test plan
npm test— 204 tests passolostep add skills && olostep list skills— names show asolostep-*olostep add skills --skill searchstill works