fix: show update notice on next run#12
Closed
ZeeshanAdilButt wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
consolidating into single PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promise.racewith a 500ms window after the command completed. For fast commands (help,version,status) the window often expired before the npm registry responded, so users never saw the update notice.showPendingUpdateNotice()— reads a notice file at process start (before command output), prints the banner, deletes the filescheduleUpdateCheck()— fires a background registry check with noawait; if a newer version is found, writes the notice file for the next runmaybeNotifyUpdateexport kept for backward compat with any direct importsTest plan
npm test— all 204 tests passOLOSTEP_NO_UPDATE_CHECK=1 olostep version— no notice written or shownolostep update— no notice written or shown