Remove MagicAccessor, add MethodHandle - upgrade to JDK 24+#103
Draft
PRIESt512 wants to merge 1 commit intoodnoklassniki:masterfrom
Draft
Remove MagicAccessor, add MethodHandle - upgrade to JDK 24+#103PRIESt512 wants to merge 1 commit intoodnoklassniki:masterfrom
PRIESt512 wants to merge 1 commit intoodnoklassniki:masterfrom
Conversation
Author
|
@lehvolk does this development branch make sense? I was expecting feedback on it) |
Collaborator
|
@PRIESt512 to be honest I've treated this branch as draft and haven't review it. Sorry for inconvenience @max-kammerer implemented a fix #104 which has been tested on internal projects and seems almost ready for publishing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
After the removal of MagicAccessorImpl, a replacement is needed to make serialization work in newer versions of Java.
A MethodHandle-based replacement was chosen as an alternative.
For BigDecimal the following classes are generated:
For all other classes, similar generation logic occurs.
This branch passes all tests except
one.nio.serial.SerializationTest#testStringBuilder,one.nio.serial.SerializationTest#testInetAddress