[seekdb][build] Remove obsolete embedded and lite build modes#1039
Open
hnwyllmm wants to merge 4 commits into
Open
[seekdb][build] Remove obsolete embedded and lite build modes#1039hnwyllmm wants to merge 4 commits into
hnwyllmm wants to merge 4 commits into
Conversation
…34820 # Conflicts # src/logservice/palf/fetch_log_engine.cpp # src/observer/ob_server.h # src/observer/ob_standby_schema_refresh_trigger.cpp # src/observer/omt/ob_multi_tenant.cpp # src/observer/omt/ob_tenant.cpp # src/observer/omt/ob_tenant.h # src/rootserver/ob_root_service.cpp
|
wangyunlai.wyl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
BUILD_EMBED_MODEmaintained a separate compile-time product variant together with obsolete in-process Embed APIs and native Arrow/Parquet support.OB_BUILD_LITEandOB_BUILD_OBSERVER_LITEwere configurable despite their false paths being stale or empty.Solution Description
BUILD_EMBED_MODEas a deprecated no-op compatibility option and makerelease_embeddeduse the same build arguments asrelease.seekdb --embeddedbehavior throughObServer::embedded_, including Unix socket, telemetry, client auto-exit, and an explicit PALF FetchLogEngine startup option.arrowTablemode.libgomp_static.alinkage, standardize former compile-time branches, and keep the embedded KV-cache bucket sizing.OB_BUILD_LITEandOB_BUILD_OBSERVER_LITEto their effective true behavior and remove the obsolete macros and false branches.Passed Regressions
release,release_embedded, andrelease -DBUILD_EMBED_MODE=ONbuilds passed; normalized compile and link graphs are identical.release_no_unityobjects compiled independently.DT_NEEDED libgomp.so.git diff --checkand cached diff checks passed.Upgrade Compatibility
Runtime
seekdb --embeddedsemantics remain compatible. The removed in-process Embed API and Parquet SQL capability are intentionally no longer supported; persisted Parquet format metadata is treated as unsupported without migration.Other Information
This MR contains only commit
b34b70375fc. The unrelated local untracked file2is not included. Documentation is intentionally unchanged.Release Note