Skip to content

[seekdb][build] Remove obsolete embedded and lite build modes#1039

Open
hnwyllmm wants to merge 4 commits into
masterfrom
task/2026071000117334820
Open

[seekdb][build] Remove obsolete embedded and lite build modes#1039
hnwyllmm wants to merge 4 commits into
masterfrom
task/2026071000117334820

Conversation

@hnwyllmm

Copy link
Copy Markdown
Member

Task Description

BUILD_EMBED_MODE maintained a separate compile-time product variant together with obsolete in-process Embed APIs and native Arrow/Parquet support. OB_BUILD_LITE and OB_BUILD_OBSERVER_LITE were configurable despite their false paths being stale or empty.

Solution Description

  • Keep BUILD_EMBED_MODE as a deprecated no-op compatibility option and make release_embedded use the same build arguments as release.
  • Preserve runtime seekdb --embedded behavior through ObServer::embedded_, including Unix socket, telemetry, client auto-exit, and an explicit PALF FetchLogEngine startup option.
  • Remove the old C/Python/JNI Embed APIs, embedded client, wheel/APK packaging, sqlite benchmark, and native Arrow/Parquet code and dependencies.
  • Return error 1235 for Parquet outfile requests while keeping CSV/ODPS/ORC enum values stable and retaining Java ODPS arrowTable mode.
  • Fix static libgomp_static.a linkage, standardize former compile-time branches, and keep the embedded KV-cache bucket sizing.
  • Collapse OB_BUILD_LITE and OB_BUILD_OBSERVER_LITE to their effective true behavior and remove the obsolete macros and false branches.

Passed Regressions

  • release, release_embedded, and release -DBUILD_EMBED_MODE=ON builds passed; normalized compile and link graphs are identical.
  • Affected release_no_unity objects compiled independently.
  • PALF FetchLogEngine disabled tests passed (4/4); KV-cache bucket test passed (1/1).
  • Normal mode TCP/SQL and FetchLogEngine startup smoke passed.
  • Embedded Unix-socket SQL, disabled FetchLogEngine, client auto-exit, and restart recovery smoke passed.
  • CSV outfile succeeded; Parquet returned 1235 without creating a file.
  • VSAG/HNSW index creation and four concurrent approximate queries passed.
  • Final ELF has static GOMP symbols and no DT_NEEDED libgomp.so.
  • git diff --check and cached diff checks passed.

Upgrade Compatibility

Runtime seekdb --embedded semantics remain compatible. The removed in-process Embed API and Parquet SQL capability are intentionally no longer supported; persisted Parquet format metadata is treated as unsupported without migration.

Other Information

This MR contains only commit b34b70375fc. The unrelated local untracked file 2 is not included. Documentation is intentionally unchanged.

Release Note

hnwyllmm and others added 4 commits July 11, 2026 15:33
…34820

# Conflicts
# src/logservice/palf/fetch_log_engine.cpp
# src/observer/ob_server.h
# src/observer/ob_standby_schema_refresh_trigger.cpp
# src/observer/omt/ob_multi_tenant.cpp
# src/observer/omt/ob_tenant.cpp
# src/observer/omt/ob_tenant.h
# src/rootserver/ob_root_service.cpp
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangyunlai.wyl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants