Skip to content

Build with Windows file descriptors#525

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
WizardCM:fix-missing-windows-resource-file
May 28, 2026
Merged

Build with Windows file descriptors#525
RytoEX merged 1 commit into
obsproject:masterfrom
WizardCM:fix-missing-windows-resource-file

Conversation

@WizardCM
Copy link
Copy Markdown
Member

@WizardCM WizardCM commented May 25, 2026

Description

Ensures the obs-browser.dll and obs-browser-page.exe files have descriptors.

image image

This reuses the versioning from the parent repository, rather than rewriting obs-browser's versioning to use cmake.

Motivation and Context

Unversioned files are unhelpful, and this makes OBS Browser consistent with most other DLLs OBS ships with.

How Has This Been Tested?

Built on Windows 10, inspected the file details.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label May 25, 2026
@RytoEX RytoEX requested review from PatTheMav and RytoEX May 26, 2026 17:58
@RytoEX RytoEX merged commit 68af8e8 into obsproject:master May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants