fix(wel): RenderingInfo format bugfix (wrap Keywords, add required Culture)#239
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
eKuG
approved these changes
Jun 9, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Change
The WEL generator emitted non-conformant
<RenderingInfo>XML. Two format fixes:<Keyword>in<Keywords>—<Keyword>elements were writtendirectly under
<RenderingInfo>; the WEL schema requires them inside a<Keywords>container.Cultureattribute —<RenderingInfo>now renders as<RenderingInfo Culture="en-US">. The attribute is required by the schema andis always present in real (WEC-forwarded, rendered-text) events.
Validation
EventType,SystemPropertiesType,RenderingInfoType) and validated a 1,900+ eventcorpus across all channels: 100% conformant after the fix.
<Keywords>wrapper and
Culture="en-US"match real output.Tests
TestEventRecordToXMLRenderingInfoKeywordsWrapperandTestEventRecordToXMLRenderingInfoCulture; updatedTestEventRecordToXML.Out of scope
TaskbeforeOpcode): intentionally left as-is.It matches the real Windows renderer, which diverges from the published XSD
ordering. Matching the renderer is the realism goal.
RenderingInfoshould be emitted at all (it only appears inWEC-forwarded rendered-text events) and locale configurability: tracked as a
separate follow-up.
Checklist