Allow Google Docs modules to write into folders they create - #341
Merged
Conversation
Static rw ACLs only cover preconfigured folder IDs, so create_folder followed by copy/upload into the new folder failed. Track creator ownership at runtime and grant the creating module write/read on those folders so template workspace clones work.
Collaborator
Author
|
Unblocks bbqd Drive workspace clone: |
harry-anderson
marked this pull request as ready for review
July 13, 2026 19:26
michelemin
requested changes
Jul 13, 2026
michelemin
left a comment
michelemin
left a comment
Collaborator
There was a problem hiding this comment.
Main comment is about reboots.
michelemin
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rwACLs only cover preconfigured Drive folder IDscreate_folderthencopy_file/upload_fileinto the new folder failed permission checksThis unblocks rules that clone a template workspace by creating a per-report folder and copying template docs into it.
Test plan
cargo test -p plaid --lib apis::gcp::google_docs::tests::permission_checks