fix: don't clear the plan when toggling a student/group selection#52
Merged
Conversation
Checking a student in the onlyFor selection cleared the plan preview (toggleTarget and the alle/keine buttons set plan = null), which was confusing. A run/schedule uses the onlyFor carried by the plan token (the subset it was planned with), not the live checkboxes, so the plan does not need clearing. Now the selection is applied only when you click "Planen"; the shown plan stays, and a small "Auswahl geändert — Planen erneut klicken" hint appears when the selection differs from what was planned. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Bug: einen Studi in der onlyFor-Auswahl ankreuzen ließ die Plan-Vorschau verschwinden (
toggleTargetund die alle/keine-Buttons setztenplan = null) — verwirrend.Ein Ausführen/Terminieren nutzt ohnehin das
onlyForaus dem Plan-Token (die Teilmenge vom Plan-Zeitpunkt), nicht die aktuellen Checkboxen — der Plan muss also nicht gelöscht werden. Jetzt wird die Auswahl erst beim Klick auf „Planen" übernommen; die gezeigte Vorschau bleibt, und ein kleiner Hinweis „Auswahl geändert — Planen erneut klicken" erscheint, wenn die Auswahl vom Geplanten abweicht.Verifikation
pnpm run check && pnpm run lint && pnpm test && pnpm run build— grün.🤖 Generated with Claude Code