Skip to content

fixed r3f example #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alouis-jpg wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixed r3f example #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions examples/r3f/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,50 @@
import * as ReactDOM from 'react-dom/client'
import { useState, useRef, Suspense } from 'react'
import { Canvas } from '@react-three/fiber'
import { PerspectiveCamera, OrbitControls } from '@react-three/drei'
import * as ReactDOM from 'react-dom/client';
import { useState, useRef, Suspense } from 'react';
import { Canvas } from '@react-three/fiber';
import { PerspectiveCamera, OrbitControls } from '@react-three/drei';
import { ErrorBoundary } from 'react-error-boundary';
import { Matrix4, Euler } from 'three'
import { Matrix4, Euler } from 'three';

import { Loader3DTilesR3FAsset } from './loader-3dtiles-r3f'
import { Loader3DTilesR3FAsset } from './loader-3dtiles-r3f';

function App() {
const camera = useRef(null);

return (
<div id="canvas-container">
<Canvas style={{ background: '#272730'}}>
<Canvas style={{ background: '#272730' }}>
<PerspectiveCamera ref={camera}>
<ErrorBoundary fallbackRender={() => (
<mesh>
<sphereGeometry />
<meshBasicMaterial color="red" />
</mesh>
)}>
<Suspense fallback={
<ErrorBoundary
fallbackRender={() => (
<mesh>
<sphereGeometry />
<meshBasicMaterial color="yellow" />
<meshBasicMaterial color="red" />
</mesh>
}>
)}
>
<Suspense
fallback={
<mesh>
<sphereGeometry />
<meshBasicMaterial color="yellow" />
</mesh>
}
>
<Loader3DTilesR3FAsset
dracoDecoderPath={"https://unpkg.com/[email protected]/examples/jsm/libs/draco"}
basisTranscoderPath={"https://unpkg.com/[email protected]/examples/jsm/libs/basis"}
rotation={new Euler(-Math.PI / 2, 0, 0)}
url="https://int.nyt.com/data/3dscenes/ONA360/TILESET/0731_FREEMAN_ALLEY_10M_A_36x8K__10K-PN_50P_DB/tileset_tileset.json"
dracoDecoderPath={'https://unpkg.com/[email protected]/examples/jsm/libs/draco'}
basisTranscoderPath={'https://unpkg.com/[email protected]/examples/jsm/libs/basis'}
rotation={new Euler(-Math.PI / 2, 0, 0)}
url="https://int.nyt.com/data/3dscenes/ONA360/TILESET/0731_FREEMAN_ALLEY_10M_A_36x8K__10K-PN_50P_DB/tileset_tileset.json"
maximumScreenSpaceError={48}
resetTransform={true}
/>
</Suspense>
</ErrorBoundary>
</PerspectiveCamera>
<OrbitControls camera={camera.current} />
</Canvas>
</div>
)
);
}

const root = ReactDOM.createRoot(document.getElementById('root'));
Expand Down
3 changes: 1 addition & 2 deletions examples/r3f/src/loader-3dtiles-r3f.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class Loader3DTilesBridge extends Loader {
onLoad(result);
}
catch(e) {
console.log("Error loading 3d tiles!", e);
onError(e);
}
}
Expand Down Expand Up @@ -44,7 +43,7 @@ function Loader3DTilesR3FAsset(props) {
})

useFrame(({ size, camera }, dt) => {
runtime.update(dt, size.height, camera);
runtime.update(dt, camera);
});

return (
Expand Down