fix(build): repair esbuild TS include so commons .ts transpiles (unblocks CI build)

[maithri471]

Problem

Now that #477 unblocked the CI build job (it bumped the hard-deprecated actions/cache@v2 → v4), build actually reaches yarn build — and fails repo-wide:

@nylas/components-booking: ../../commons/src/define-component-patch.ts (4:36)
4: window.customElements.define = (name: string, ...args) => {
                                        ^
[!] Error: Unexpected token (Note that you need plugins to import files that are not JavaScript)

main is red and this blocks every PR.

Root cause

rollup.common.config.js gates esbuild's TypeScript transpile with a glob:

esbuild({ include: [`${ROOT}/**/*.ts+(|x)`], ... })

That +(|x) extglob no longer matches .ts files under picomatch 4.x. The repo ships a yarn.lock, but CI installs with npm install, which ignores yarn.lock — so picomatch floats to 4.x and esbuild silently stops transpiling all TypeScript. Every component build then dies on the first raw .ts import (commons/src/define-component-patch.ts). It stayed hidden because CI's build job used to die at the actions/cache@v2 setup gate before yarn build ever ran.

Fix

Replace the fragile, cwd-/picomatch-dependent glob with a regex:

esbuild({ include: /\.tsx?$/, ... })

Verification

Reproduced and fixed with the repo's exact plugin versions ([email protected], [email protected]) against the real offending file:

• old include: ['**/*.ts+(|x)'] → Unexpected token (bug reproduced)
• new include: /\.tsx?$/ → clean build; output transpiled (name: string → name)

Also confirmed at the filter layer: createFilter(['../../**/*.ts+(|x)']) returns false for the commons .ts file; the regex returns true. Final end-to-end check is this PR's CI run (Linux + node 14, where node-sass compiles — it won't build on macOS locally).

Follow-ups (separate)

• Align lockfile/CI — the root fragility is yarn.lock + npm install. Use yarn install --frozen-lockfile (or commit package-lock.json + npm ci) so transitive deps can't drift like this again.
• Soft-deprecated actions/checkout@v2, actions/setup-node@v2, ::set-output in the workflow.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
components	Error		Jun 22, 2026 7:30pm
components-pnmt	Error		Jun 22, 2026 7:30pm