feat: support Takumi v2 compatibility#635
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
https://takumi.kane.tw/docs/upgrade/v2
Type of change
Description
Adds Takumi v2 support without dropping v1.
module.tsdetects the installed Takumi major and passes that metadata into the runtime compatibility payload, so the renderer can choose the right API at runtime.The Takumi renderer keeps the v1
loadFontpath and uses v2 render-localfontsandimages. It still fetches fonts and assets before rendering, which keeps Cloudflare Workers and other non-standard runtimes from depending on Takumi to fetch those resources.The test pipeline now runs Takumi e2e coverage against v1 and v2, with a pixel compare path for representative PNG output.
Testing
pnpm lint && pnpm typecheck && pnpm buildpnpm run test:takumi:e2e:matrixpnpm run test:takumi:e2e:compare