Security: Potential Prototype Pollution in p-all.js - #1124
Open
tomaioo wants to merge 1 commit into
Open
Conversation
In workspaces/data/lib/p-all.js, the function uses `Object.entries(promises)` and later `Object.fromEntries(result)`. If user-controlled input is passed as the `promises` object, and the object contains keys like `__proto__`, `constructor`, or `prototype`, this could lead to prototype pollution when `Object.fromEntries` is called. While the current usage may be internal, the function is exported and could be used with untrusted input. Signed-off-by: tomaioo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential Prototype Pollution in p-all.js
Problem
Severity:
Medium| File:workspaces/data/lib/p-all.js:L5In workspaces/data/lib/p-all.js, the function uses
Object.entries(promises)and laterObject.fromEntries(result). If user-controlled input is passed as thepromisesobject, and the object contains keys like__proto__,constructor, orprototype, this could lead to prototype pollution whenObject.fromEntriesis called. While the current usage may be internal, the function is exported and could be used with untrusted input.Solution
Add validation to reject dangerous keys (
__proto__,constructor,prototype) before processing, or use a null prototype object (Object.create(null)) to prevent prototype pollution.Changes
workspaces/data/lib/p-all.js(modified)