Skip to content

fix(arborist): warn once for workspace packageExtensions selector match #9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owlstronaut merged 1 commit into from
Jun 18, 2026
+7 −3
Merged

fix(arborist): warn once for workspace packageExtensions selector match #9570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion workspaces/arborist/lib/arborist/build-ideal-tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,8 @@ module.exports = cls => class IdealTreeBuilder extends cls {
return
}
for (const node of this.idealTree.inventory.values()) {
if (!node.isWorkspace) {
// a workspace is in the inventory as both a Link and its target node; warn once by skipping the link
if (!node.isWorkspace || node.isLink) {
continue
}
if (node.package.packageExtensions !== undefined) {
Expand Down
7 changes: 5 additions & 2 deletions workspaces/arborist/test/arborist/package-extensions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,11 @@ t.test('does not extend workspace members but warns', async t => {
const tree = await buildIdeal(path)
const ws = [...tree.inventory.values()].find(n => n.name === 'ws')
t.notOk(ws.edgesOut.get('bar'), 'workspace member is not extended')
t.ok(warnings.some(w => /workspace package ws/.test(w[2])), 'warns about the workspace selector match')
t.ok(warnings.some(w => /in workspace ws is ignored/.test(w[2])), 'warns about non-root workspace packageExtensions')
// a workspace appears in the inventory as both a Link and its target node, so the warning must be deduped to fire once
t.equal(warnings.filter(w => /workspace package ws/.test(w[2])).length, 1,
'warns exactly once about the workspace selector match')
t.equal(warnings.filter(w => /in workspace ws is ignored/.test(w[2])).length, 1,
'warns exactly once about non-root workspace packageExtensions')
})

t.test('ignores packageExtensions from an installed dependency', async t => {
Expand Down
Loading