Add configurable keyboard event routing#48
Merged
satoshi-szk merged 2 commits intoJul 4, 2026
Merged
Conversation
Route key events and accelerator-style shortcuts through an explicit policy so embedded WebViews can keep application shortcuts while forwarding selected host keys. The policy replaces the older key-only route list and keeps the WebView2/macOS backends aligned.
Child WebViews rely on the wrapper for AppKit accelerator routing. Reparenting only the inner WKWebView would bypass that wrapper after moving the view to another window.
satoshi-szk
marked this pull request as ready for review
July 4, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Embedded plugin UIs need WebView-owned shortcuts such as primary-modifier undo/redo to stay inside the WebView while selected host keys such as Space can still reach the parent host view. A key-only route list made that behavior ambiguous, especially for command-key paths on macOS.
Validation