Skip to content

Clean public API boundaries#43

Merged
satoshi-szk merged 3 commits into
novonotes:novonotes-internalfrom
satoshi-assistant:codex/clean-public-api
Jun 17, 2026
Merged

Clean public API boundaries#43
satoshi-szk merged 3 commits into
novonotes:novonotes-internalfrom
satoshi-assistant:codex/clean-public-api

Conversation

@satoshi-assistant

Copy link
Copy Markdown
Contributor

Summary

  • make RunLoopSender and run loop platform internals private to the crate
  • move run loop test helpers into a dedicated run_loop_test_utils crate
  • replace the hidden wxp command deserialization extension with explicit CommandContext::channel()
  • update docs and examples to match the cleaned public API

Verification

  • cargo fmt --all
  • git diff --check
  • cargo clippy --workspace --exclude wry --all-targets --no-deps -- -D warnings
  • cargo test --workspace

Remove hidden public APIs from run_loop and wxp so the exposed surface matches the intended post/call and explicit channel APIs.

Move run loop test helpers into a dedicated test-utils crate and tighten internal visibility with workspace lints.
Linux and Windows CI build target-specific FFI modules that were not checked on macOS.

Keep the run_loop unreachable_pub cleanup complete across platform backends and include the new test-utils crate in CI formatting.
WebView dispatch now routes through the process-wide run loop API, so the WebView owner must keep the original run loop binding active for its native lifetime.
@satoshi-szk
satoshi-szk changed the base branch from main to novonotes-internal June 17, 2026 18:39
@satoshi-szk
satoshi-szk merged commit e0b0db3 into novonotes:novonotes-internal Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants