This repository was archived by the owner on May 18, 2026. It is now read-only.
Avoid blocking WebView2 creation with message pump#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Windows, Ableton Live can intermittently crash when an embedded plug-in editor is opened/closed rapidly. The crash is triggered around WebView2 creation: the current Windows backend synchronously waits for environment/controller callbacks using a nested message pump, so host GUI lifecycle callbacks can be dispatched while
set_parent/showis still on the stack.This patch moves WebView2 creation to callback continuation style instead of waiting. That makes the diff larger than a local lock or debounce workaround because
InnerWebView::newcan now return before the native WebView2 controller exists, so the Windows backend needs explicit pending state for operations that may arrive during creation.Summary
controller()extension returnOptionbecause the controller may now be pending.Validation
cargo fmt --all -- --checkpassed.cargo checkinwrypassed.wrac-plugin-templatevia local patch.cargo check -p wrac_wxp_gui -p wrac_gain_plugin --all-targetspassed.cargo xtask build --release --target=clap,vst3passed.