Bundle kotlin-reflect so dependents get working Kotlin reflection#16
Open
Chaosgh wants to merge 2 commits into
Open
Bundle kotlin-reflect so dependents get working Kotlin reflection#16Chaosgh wants to merge 2 commits into
Chaosgh wants to merge 2 commits into
Conversation
InjectLib provides the shared kotlin-stdlib + inits kotlin.jvm.internal.Reflection before dependents load. Without reflect here, Reflection's factory is fixed to 'no reflection', so plugins (e.g. TransientCore item serialization via jackson-module-kotlin) hit KotlinReflectionNotSupportedError even when they shade their own reflect. Ship reflect alongside stdlib. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Dependents compile against Kotlin 2.3.x; the shared stdlib must be >= theirs. kotlin.jvm.internal.KotlinGenericDeclaration is a 2.3.20 stdlib class that kotlin-reflect 2.3.20 references, so stdlib+reflect must both be 2.3.20. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
InjectLib is loaded first and provides the shared kotlin-stdlib for dependent plugins. When its
kotlin.jvm.internal.Reflectionclass initializes (at InjectLib load time), it fixes the reflection factory based on whetherkotlin-reflectis on its classloader. InjectLib ships stdlib but not kotlin-reflect, so the factory is permanently set to "no reflection".As a result, dependents hit
KotlinReflectionNotSupportedErrorat runtime — even when they shade their own kotlin-reflect, because their copy lives on a child classloader that InjectLib's already-initializedReflectioncan't see. On Minecraft 26.1.2 this broke e.g. TransientCore's item serialization (jackson-module-kotlin), cascading to several plugins failing to enable.Fix
Ship
kotlin-reflectalongsidekotlin-stdlib-jdk8(same${kotlin.version}) so it's shaded into the InjectLib jar. Then InjectLib'sReflectioninitializes with the reflection factory available, and every dependent gets working Kotlin reflection.Verified: the built jar now contains
kotlin/reflect/jvm/internal/ReflectionFactoryImplalongside the stdlib.