Skip to content

fix(sdd-derive): reword the derive-spec offer as helpful, not a callout#329

Merged
norrietaylor merged 1 commit into
mainfrom
fix/derive-spec-offer-copy
Jul 7, 2026
Merged

fix(sdd-derive): reword the derive-spec offer as helpful, not a callout#329
norrietaylor merged 1 commit into
mainfrom
fix/derive-spec-offer-copy

Conversation

@norrietaylor

Copy link
Copy Markdown
Owner

Closes #328.

Rewords the sdd-derive unspecced-PR offer (wrappers/sdd-derive.yml) so it reads as useful help rather than a callout for incomplete work.

Before:

This pull request has no accompanying spec. Comment /derive-spec to have one derived retrospectively from the code — … gap analysis (implementation gaps, missing failure paths, weak acceptance criteria). Ignore this to defer; the weekly unspecced-PR scan will re-surface it. See ADR 0027.

After:

📋 Want a spec for this — derived from your code, for free? Comment /derive-spec and the pipeline writes one from the diff: a separate spec/<slug> doc PR capturing this feature's demoable units and acceptance criteria, plus a quick second pass on edge cases and failure paths worth a look before review. Optional, and it touches nothing here — skip it and nothing changes.

Value-first; the gap check is reframed as a pre-review safety net, not a fault list; declining is cost-free; ADR ref dropped from the dev-facing copy. Behavior unchanged (idempotent, size-gated, docs-only/already-specced still skipped). Wrapper-only — no lock recompile.

🤖 Generated with Claude Code

The unspecced-PR offer opened with a deficiency ('has no accompanying
spec'), foregrounded a fault list ('implementation gaps, missing failure
paths, weak acceptance criteria'), and nagged ('will re-surface it') —
reading like a report card on a contributor's work. Lead with the value
(a free spec derived from their code + a light pre-review gap check),
frame declining as cost-free, and drop the nag.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
Claude-Session: https://claude.ai/code/session_0143kv2BRrRqGxmVwwHskQtS
@norrietaylor norrietaylor enabled auto-merge June 30, 2026 23:24
@norrietaylor

Copy link
Copy Markdown
Owner Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b01f2ea9-b999-45b1-8e7d-cbd88da7a4d3

📥 Commits

Reviewing files that changed from the base of the PR and between d928c5f and d9e6fc6.

📒 Files selected for processing (1)
  • wrappers/sdd-derive.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the message shown when the spec-derivation offer is posted.
    • The prompt is now shorter and clearer, telling users to comment /derive-spec to generate a derived spec PR.
    • It also explains that an optional second pass is available and that skipping the prompt leaves everything unchanged.

Walkthrough

The PR updates the deterministic comment text posted by the offer job in wrappers/sdd-derive.yml. The prior "no accompanying spec"/defer wording is replaced with a shorter message prompting /derive-spec, describing the derived spec PR and optional edge-case pass. No functional or comment-marker logic changes.

Changes

Offer Comment Text Update

Layer / File(s) Summary
Rework offer comment copy
wrappers/sdd-derive.yml
The offer job's GitHub-script comment text is replaced, dropping "no accompanying spec"/defer wording in favor of a call-to-action describing /derive-spec, the derived spec PR contents, and the cost-free skip option.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • norrietaylor/spectacles#276: Introduced the same sdd-derive offer/<!-- sdd-derive:offer --> comment mechanism whose text is edited here.

Poem

A rabbit hops with a friendlier note,
No more scolding words to quote,
"/derive-spec" — a gift, not a chore,
Skip it freely, nothing more,
Hooray for copy devs adore! 🐇📋

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The copy rewrite aligns with #328, but the PR doesn't address the contributor-facing label concern, so it falls short of the issue. Rename or drop the needs-spec label from the contributor-facing flow, or document why it remains acceptable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: rewording the sdd-derive offer to sound helpful.
Description check ✅ Passed The description clearly matches the comment rewrite and unchanged behavior in wrappers/sdd-derive.yml.
Out of Scope Changes check ✅ Passed The change stays scoped to rewording the offer text and doesn't introduce unrelated behavior changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/derive-spec-offer-copy

Comment @coderabbitai help to get the list of available commands.

@norrietaylor norrietaylor merged commit 1e70eb0 into main Jul 7, 2026
13 checks passed
@norrietaylor norrietaylor deleted the fix/derive-spec-offer-copy branch July 7, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdd-derive: reword the derive-spec offer to read as useful help, not a callout for incomplete work

1 participant