1.6.1 hotfix#1
Open
nn1900 wants to merge 11 commits into
Open
Conversation
Resolve conflicts
Signed-off-by: Joe Mattiello <[email protected]>
Signed-off-by: Joe Mattiello <[email protected]>
Signed-off-by: Joe Mattiello <[email protected]>
|
Hey @nn1900, thank you this awesome hotfix. Please consider creating this pull request to original repository. |
Owner
Author
|
Sure. I have created the pull request HeroTransitions#730. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the following fixes included:
modalPresentationStyleset tooverFullScreen(orformSheetorautomaticfor regular height size class) in which case the presenting view controller's view will not removed from the view hierarchy but instead shown beneath the presented view controller, and then dismiss the presented view controller, the presenting view controller's view leaks.A), which is presented withmodalPresentationStyleset tooverFullScreen(orformSheetorautomaticfor regular height size class), itself presents anotherfullScreen(orformSheetorautomaticfor compact height size class) view controller (denoted asB) w/ hero transition enabled. After the presented view controllerBis dismissed, the view controllerA's frame will be changed to be full screen, what's worse, cannot be dismissed by using pan gesture.