Skip to content

1.6.1 hotfix#1

Open
nn1900 wants to merge 11 commits into
developfrom
1.6.1-hotfix
Open

1.6.1 hotfix#1
nn1900 wants to merge 11 commits into
developfrom
1.6.1-hotfix

Conversation

@nn1900

@nn1900 nn1900 commented Apr 19, 2021

Copy link
Copy Markdown
Owner

the following fixes included:

  • when a a view controller that is deep nested under some exotic view hierarchy (e.g., react native component view) presents a view controller w/ hero transition and modalPresentationStyle set to overFullScreen (or formSheet or automatic for regular height size class) in which case the presenting view controller's view will not removed from the view hierarchy but instead shown beneath the presented view controller, and then dismiss the presented view controller, the presenting view controller's view leaks.
  • when a view controller (denoted as A), which is presented with modalPresentationStyle set to overFullScreen (or formSheet or automatic for regular height size class), itself presents another fullScreen (or formSheet or automatic for compact height size class) view controller (denoted as B) w/ hero transition enabled. After the presented view controller B is dismissed, the view controller A's frame will be changed to be full screen, what's worse, cannot be dismissed by using pan gesture.

@machl

machl commented Feb 8, 2022

Copy link
Copy Markdown

Hey @nn1900, thank you this awesome hotfix.
It looks like a fix for well known issue HeroTransitions#644

Please consider creating this pull request to original repository.

@nn1900

nn1900 commented Feb 8, 2022

Copy link
Copy Markdown
Owner Author

Sure. I have created the pull request HeroTransitions#730. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants