Deduplicate PK/FK classification SQL (share the CTE form)#124
Merged
Conversation
ListColumns used correlated EXISTS subqueries per column while FetchDatabaseMetadata used a faster CTE + LEFT JOIN for the same rule. Extract a single parameterized columnClassificationSQL (CTE form) used by both paths: NULL/NULL selects every user-schema table (whole-DB), schema/table scopes to one table. Per-table results are unchanged. Closes #119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119.
What changed
ListColumnsclassified PK/FK with correlatedEXISTSsubqueries per column, whileFetchDatabaseMetadataused a faster CTE + LEFT JOIN for the same rule — two implementations that drift, with the slower form in the per-table path.Extracted a single
columnClassificationSQL(the CTE + LEFT JOIN form) shared by both paths:$1/$2= schema/table; passingNULL/NULLselects every user-schema table (whole-DB mode, used byFetchDatabaseMetadata) and excludes system schemas.ListColumns).The system-schema exclusion applies only in whole-DB mode, so per-table results are byte-for-byte unchanged.
Acceptance criteria
Testing
TEST_DB_URL=... go test .— pass (unit + integration)