chore: drop unused shadcn scaffolding#122
Merged
Merged
Conversation
The shadcn setup was scaffolded but never used: no src/components/ui, and cn() (the only consumer of clsx + tailwind-merge) was referenced only by a smoke test. class-variance-authority was never imported at all. - Remove cn() and its imports from src/lib/utils.ts (keep fmtDuration) - Drop the cn test block from smoke.test.ts - Delete components.json (shadcn CLI config) - Uninstall clsx, tailwind-merge, class-variance-authority Verified: build succeeds and 438/438 frontend tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #121. Removes the shadcn/ui scaffolding, which was set up but never actually used.
src/components/uidirectory ever existed.cn()(the sole consumer ofclsx+tailwind-merge) was referenced only by a smoke test.class-variance-authoritywas never imported anywhere.Changes
cn()and its imports fromsrc/lib/utils.ts(keepfmtDuration, which HistoryDrawer uses).cntest block fromsmoke.test.ts.components.json(shadcn CLI config).clsx,tailwind-merge,class-variance-authority.Verification
npm run build— succeeds (tsc clean, no dangling references).npm run test— 438/438 pass (was 440; the 2 removed tests werecn's).