fix: restore search, directions, and settings interactions#1627
fix: restore search, directions, and settings interactions#1627DeBaschdi wants to merge 3 commits into
Conversation
Signed-off-by: Bastian Kleinschmidt <[email protected]>
Signed-off-by: Bastian Kleinschmidt <[email protected]>
Signed-off-by: Bastian Kleinschmidt <[email protected]>
9507509 to
27437b4
Compare
|
Very very cool!! Did some smoke testing and some minor interface issues came up. Let me know if that's at all related here or separate. :) Mostly missing icons: Missing icons in nav, menus and "Clear POIs" button
Missing icons for further overlay switcher and location toggle
Missing icons for favorite sidebar
Missing icon on favorite marker on mapIt's there in the left nav though. A local review with Claude Opus 4.8 pointed out these things:
Note that it would be good to add this info to the commits as per the contribution guidelines. Just a simple line with the proper trailer which lists the tool and model+version is enough :) |
|
Oh and while we're at it, you could also set the max-version to 36 or so? :) |
|
I'll take another look to see what might be wrong with the icons. |
|
I tested the Maps settings portion locally on Nextcloud 33.0.3 / Maps 1.7.1 / Chrome 150 by applying the equivalent compiled-bundle changes. Confirmed working after the
There is still a UX/behavior problem with Open geo links in this PR: the component is bound to I recommend changing that third control to an |




Summary
Validation
AI (if applicable)
Fixes #1596
Fixes #1614