feat(navigation): restore address book navigation in sidebar#5421
Open
pagaille wants to merge 2 commits into
Open
feat(navigation): restore address book navigation in sidebar#5421pagaille wants to merge 2 commits into
pagaille wants to merge 2 commits into
Conversation
added 2 commits
July 1, 2026 17:43
Address books used to be listed in the left sidebar (via the now-deleted SettingsSection.vue), allowing users to click on a book to filter their contacts. This was removed in bd536c0 when settings were migrated to a modal dialog, without any navigation replacement — making the "New address book" feature essentially invisible and unusable. Changes: - Add "Address books" section in RootNavigation with one item per enabled address book and a contact counter - Add ROUTE_ADDRESSBOOK constant and addressbook/:selectedAddressbook route - Add selectedAddressbook to RouterMixin - Filter contactsList by selected address book when on the addressbook route - New contacts created while an address book is selected are saved into that address book instead of the default one - Prevent "Missing required param selectedGroup" errors in selectFirstContactIfNone() and ContactsListItem when on the addressbook route by using GROUP_ALL_CONTACTS as fallback Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Matthieu <[email protected]>
Address books used to be listed in the left sidebar (via the now-deleted SettingsSection.vue), allowing users to click on a book to filter their contacts. This was removed in bd536c0 when settings were migrated to a modal dialog, without any navigation replacement — making the "New address book" feature essentially invisible and unusable. Changes: - Add "Address books" section in RootNavigation with one item per enabled address book and a contact counter - Add ROUTE_ADDRESSBOOK constant and addressbook/:selectedAddressbook and addressbook/:selectedAddressbook/:selectedContact routes - Add selectedAddressbook to RouterMixin - Filter contactsList by selected address book when on the addressbook route - New contacts created while an address book is selected are saved into that address book instead of the default one - Fix "Missing required param selectedGroup" errors in selectFirstContactIfNone(), ContactsListItem, and ContactDetails (moveContactToAddressbook / copyContactToAddressbook) when navigating without a selectedGroup param Fixes nextcloud#3647 Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Matthieu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3647
Summary
Address books used to be listed in the left sidebar (via the now-deleted
SettingsSection.vue), allowing users to click on a book to filter their contacts. This was removed in bd536c0 when settings were migrated to a modal dialog, without any navigation replacement — making the "New address book" feature essentially invisible and unusable.Changes:
ROUTE_ADDRESSBOOKconstant andaddressbook/:selectedAddressbook+addressbook/:selectedAddressbook/:selectedContactroutesselectedAddressbooktoRouterMixincontactsListby the selected address book when on the addressbook routeMissing required param "selectedGroup"errors inselectFirstContactIfNone(),ContactsListItem, andContactDetails(moveContactToAddressbook/copyContactToAddressbook) when navigating without aselectedGroupparamTest plan
🤖 Generated with Claude Code