Improve activity feed design#2634
Open
jancborchardt wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
308b49e to
e8f2b72
Compare
The <h1> showed the active filter's name, which the app navigation already indicates, so it only added visual noise. Keep it in the DOM for document semantics and screen readers but hide it with hidden-visually, and drop its now-unused visual styling so it cannot affect layout. Adjust the stream e2e tests to assert the heading's content rather than its visibility. AI-assisted: Claude Code (Opus 4.8) Signed-off-by: Jan C. Borchardt <[email protected]>
The scroll container was the centred, max-width content column, so its scrollbar floated in the middle of the viewport. Move scrolling to the full-width container and clamp the readable column in an inner wrapper, so the scrollbar sits at the edge of app-content while the content stays readable. The column width becomes a shared --activity-feed-max-width. AI-assisted: Claude Code (Opus 4.8) Signed-off-by: Jan C. Borchardt <[email protected]>
Group each day's activities in a section whose date heading sticks to the top while that day is in view, with the next day pushing the previous one up. The heading fades feed items out beneath it and is sized/aligned to the app navigation toggle. Its indent to clear the toggle eases in from the content-area width (a query container), so it accounts for the space the open navigation takes rather than the raw viewport. Add unit tests for the heading's Today/Yesterday/full-date labels. AI-assisted: Claude Code (Opus 4.8) Signed-off-by: Jan C. Borchardt <[email protected]>
Give the "No more activities." message generous, viewport-scaled space below it so the end of the feed isn't cramped against the bottom edge. AI-assisted: Claude Code (Opus 4.8) Signed-off-by: Jan C. Borchardt <[email protected]>
e8f2b72 to
1956162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve overall design of activity feed:
Before
Screencast.From.2026-06-02.02-09-05.webm
After
Screencast.From.2026-06-02.01-59-25.webm
Breakpoint example:
Screencast.From.2026-06-02.02-01-05.webm
AI-assisted: Claude Code (Opus 4.8)