fix(providers): normalize email in WebAuthn getUserInfo#13415
Open
iruizsalinas wants to merge 1 commit intonextauthjs:mainfrom
Open
fix(providers): normalize email in WebAuthn getUserInfo#13415iruizsalinas wants to merge 1 commit intonextauthjs:mainfrom
iruizsalinas wants to merge 1 commit intonextauthjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@iruizsalinas is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebAuthn provider's
getUserInfopasses the raw email straight toadapter.getUserByEmail, while the email and OAuth providers both normalize it first (lowercase + trim insend-token.ts,.toLowerCase()in the OAuth callback).On adapters where
getUserByEmailis case-sensitive, a user who registers a passkey with[email protected]won't match when they later sign in with[email protected], and can end up with a duplicate account.Just aligning WebAuthn with how the other providers already handle email input.