Skip to content

Fix WPA-sec credential identity parsing - #16

Merged
newfpv merged 1 commit into
mainfrom
agent/wpa-sec-compact-potfile
Jul 28, 2026
Merged

Fix WPA-sec credential identity parsing#16
newfpv merged 1 commit into
mainfrom
agent/wpa-sec-compact-potfile

Conversation

@newfpv

@newfpv newfpv commented Jul 28, 2026

Copy link
Copy Markdown
Owner

What changed

  • parse WPA-sec result lines whose BSSID and station fields use compact 12-hex MAC notation
  • preserve the exact BSSID instead of producing Name-only credential records
  • merge identical WPA-sec and other-source credentials by BSSID/password
  • keep access points with the same ESSID/password separate when their BSSIDs differ
  • preserve passwords containing colons
  • bump PWMenu to 1.3.8 and update the tagged install URL and changelog

Root cause

WPA-sec downloads BSSID:STATION:ESSID:PASSWORD with compact MAC fields such as aabbccddeeff. PWMenu only accepted colon-delimited MAC fields, so it fell back to an ESSID/password-only parser and discarded the BSSID.

Validation

  • python -m unittest discover -s tests -v
  • 52 tests passed, including three new WPA-sec compact-potfile regression tests
  • git diff --check passed

@newfpv
newfpv marked this pull request as ready for review July 28, 2026 23:47
@newfpv
newfpv merged commit b0b135f into main Jul 28, 2026
2 checks passed
@newfpv
newfpv deleted the agent/wpa-sec-compact-potfile branch July 28, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant