Update flash messages#397
Draft
lleger wants to merge 3 commits into
Draft
Conversation
Also updates generated files from new Phoenix project. I updated this manually comparing a fresh Phoenix 1.6.11. I also used the [PhoenixDiff] project to double check. [phoenixdiff]: https://www.phoenixdiff.org/?source=1.5.6&target=1.6.11
- Make them human readable by default - Restyle with Tailwind - Use gettext for strings - Use new Phoenix components instead of content_tag
By default, let's leave it just as the root domain, since that is what we'll use by default. If an app needs a subdomain, it can be added in that app specifically -- but this is a business decision, not a general one.
|
This pull request has been linked to Shortcut Story #18131: Human readable error messages by default. |
Member
Author
|
This will need to be rebased once #395 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update flash messages
Closes [sc-18131].
Update CSP to not include subdomain
By default, let's leave it just as the root domain, since that is what
we'll use by default. If an app needs a subdomain, it can be added in
that app specifically -- but this is a business decision, not a general
one.
Screenshots
QA Notes
PR Author Browser Info: Safari