This repository was archived by the owner on Jul 14, 2026. It is now read-only.
chore: fix proto script file handling and safety - #977
Open
mdqst wants to merge 1 commit into
Open
Conversation
Collaborator
|
Resolve conflicts, please |
mmikev
suggested changes
Nov 11, 2025
| cd .. | ||
|
|
||
| # move proto files to the right places | ||
| mkdir -p x |
Collaborator
There was a problem hiding this comment.
I don't think it makes sense to create the x folder, it must always be here.
| mkdir -p x | ||
| cp -r github.com/neutron-org/neutron/v8/x/* x/ | ||
| rm -rf github.com | ||
| rm -rf github.com/neutron-org |
Collaborator
There was a problem hiding this comment.
This command will not remove the github.com directory itself, so it doesn't make sense to narrow the command down to neutron-org
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
()aroundgo install …to avoid spawning a useless subshell..protofiles with spaces or special characters:for file in $(find …)→find … -print0 | while IFS= read -r -d '' file.grep "option go_package"togrep -q "option go_package" "$file"for quiet search and proper quoting.cd proto || exit 1to stop the script if the directory doesn’t exist.x/directory before copying files to prevent errors:mkdir -p x.rm -rfto only remove the target subdirectory (github.com/neutron-org) instead of the wholegithub.com.changes make the script safer, more robust, and prevent accidental deletion or errors when handling files with tricky names.