Detect install location and allow ripgrep from PATH#1
Open
idbrii wants to merge 2 commits into
Open
Conversation
Use CallerFilePath to fetch the install directory for the ignore file.
If rg isn't in the assumed location, assume it's in the PATH. Everything should continue working as before, but people who have it in their PATH don't need to install it in each of their Unity projects. Add instructions when ripgrep cannot be found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the install directory, use CallerFilePath to detect it. Instead of requiring a specific location for rg, allow it to be in the PATH. This gives users a lot more freedom for how to install this plugin.