feat(serviceAccount): support custom annotations on the service account#537
Conversation
Add a serviceAccount.annotations value and render it onto the ServiceAccount
metadata. Enables setting annotations natively (e.g. an AWS IRSA
eks.amazonaws.com/role-arn) instead of patching the chart-created SA after
install. Defaults to {} so existing releases are unaffected.
|
Mateusz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds first-class support for custom Kubernetes ServiceAccount annotations in the Netdata Helm chart, enabling use-cases like AWS IRSA without post-install patching.
Changes:
- Introduces
serviceAccount.annotationsinvalues.yamlwith a default of{}. - Renders
serviceAccount.annotationsinto the ServiceAccount manifest metadata when provided. - Documents the new value in the chart README values table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/netdata/values.yaml | Adds serviceAccount.annotations value with an empty-map default. |
| charts/netdata/templates/serviceaccount.yaml | Conditionally renders annotations under ServiceAccount metadata. |
| charts/netdata/README.md | Documents the new serviceAccount.annotations chart value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a serviceAccount.annotations value and render it onto the ServiceAccount metadata. Enables setting annotations natively (e.g. an AWS IRSA eks.amazonaws.com/role-arn) instead of patching the chart-created SA after install. Defaults to {} so existing releases are unaffected.