Skip to content

feat(serviceAccount): support custom annotations on the service account#537

Merged
ilyam8 merged 1 commit into
masterfrom
netdata-sa-annotation
Jul 3, 2026
Merged

feat(serviceAccount): support custom annotations on the service account#537
ilyam8 merged 1 commit into
masterfrom
netdata-sa-annotation

Conversation

@mtblz

@mtblz mtblz commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Add a serviceAccount.annotations value and render it onto the ServiceAccount metadata. Enables setting annotations natively (e.g. an AWS IRSA eks.amazonaws.com/role-arn) instead of patching the chart-created SA after install. Defaults to {} so existing releases are unaffected.

Add a serviceAccount.annotations value and render it onto the ServiceAccount
metadata. Enables setting annotations natively (e.g. an AWS IRSA
eks.amazonaws.com/role-arn) instead of patching the chart-created SA after
install. Defaults to {} so existing releases are unaffected.
@mtblz mtblz requested review from a team and ilyam8 as code owners July 3, 2026 12:14
@mtblz mtblz requested a review from witalisoft July 3, 2026 12:14
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mateusz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ilyam8 ilyam8 requested review from Copilot July 3, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds first-class support for custom Kubernetes ServiceAccount annotations in the Netdata Helm chart, enabling use-cases like AWS IRSA without post-install patching.

Changes:

  • Introduces serviceAccount.annotations in values.yaml with a default of {}.
  • Renders serviceAccount.annotations into the ServiceAccount manifest metadata when provided.
  • Documents the new value in the chart README values table.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
charts/netdata/values.yaml Adds serviceAccount.annotations value with an empty-map default.
charts/netdata/templates/serviceaccount.yaml Conditionally renders annotations under ServiceAccount metadata.
charts/netdata/README.md Documents the new serviceAccount.annotations chart value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ilyam8 ilyam8 merged commit 55ac8eb into master Jul 3, 2026
2 of 3 checks passed
@ilyam8 ilyam8 deleted the netdata-sa-annotation branch July 3, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants