fix: gate deploy cancellation to non-main refs - #222
Merged
Conversation
`cancel-in-progress: true` applied to `main`, so a rapid second push could cancel an in-flight production deploy. A cancelled deploy is not a no-op: the upload and the activation are separate steps, so stopping between them can leave a state matching no commit. This workflow only triggers on `main`, so the effect is to turn cancellation off. The expression is written as in the other repositories receiving this fix, keeping the workflows comparable and staying correct if a `pull_request` trigger is added later. Propagated from nemolize/web-app-template#358. Tracked in nemolize/web-app-template#359.
nemolize
marked this pull request as ready for review
July 27, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates a deploy-workflow fix from the
web-app-templatethis repository was created from. Tracked in nemolize/web-app-template#359; the fix itself is nemolize/web-app-template#358.Changes
cancel-in-progresscould cancel an in-flight production deploycancel-in-progress: trueapplied tomain, so a rapid second push could cancel a deploy partway through. A cancelled deploy is not a no-op: the upload and the activation are separate steps, so stopping between them can leave a state that matches no commit, and nothing re-runs to correct it.This workflow only triggers on
main, so the effect is to turn cancellation off. The expression is written the same way as in the other repositories receiving this fix, so the workflows stay comparable and it stays correct if apull_requesttrigger is added later.The workflow-level
pull-requests: writefix in the tracking issue does not apply here — this workflow does not request that permission.Impact
CI/CD configuration only. No application code changes. Consecutive pushes to
mainnow queue rather than cancel, so the last push still wins — it just waits instead of interrupting.Test plan
actionlintpasses