fix(frontend): fix spacing and alignment inconsistencies#29
Open
tkitsunai wants to merge 1 commit into
Open
Conversation
Several small styling inconsistencies found across pages: - Left-align player name text in table row buttons (HistoryRow, TopGlobal, TopPlayer, Search, Legend), removing MUI Button's default min-width so left-aligned text doesn't leave an awkward gap for short names - Fix uneven top/bottom padding in the page header AppBar (Legend, Search, Stats, TopGlobal, TopPlayer) by switching to flex centering instead of a fixed paddingTop with no paddingBottom - Add missing margin between pagination controls and the table, on both sides (TopGlobal, TopPlayer, Player match history) - Vertically align the rank badge, player name, and tags in the Player page header by wrapping them in a flex container, and remove magic-number `top` offsets from the platform/global_rank/ char_rank Typography variants (replaced with vertical-align: middle where the parent isn't a flex container)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several small styling inconsistencies found while browsing the app:
HistoryRow,TopGlobal,TopPlayer,Search,Legend), removing MUI Button'sdefault
min-widthso left-aligned text doesn't leave an awkwardgap for short names
AppBar(Legend,Search,Stats,TopGlobal,TopPlayer) by switching to flexcentering instead of a fixed
paddingTopwith nopaddingBottomboth sides (
TopGlobal,TopPlayer, Player match history)Player page header by wrapping them in a flex container, and remove
magic-number
topoffsets from theplatform/global_rank/char_rankTypography variants (replaced withvertical-align: middlewhere the parent isn't a flex container)Discussion: acceptable trade-off?
Removing
min-widthfrom the player-name buttons also shrinks theclickable/hoverable area for short names down to the text's own
width. The hover style (color etc.) doesn't change, but the hover
area does. Flagging this before merge — is that an acceptable
trade-off?
Test plan
npm run typecheck— no errorsnpm run check(biome) — no errorsnpm test(vitest) — 82 tests passing5 affected pages, AppBar header spacing, pagination margins,
Player page header layout (including the tag-wrap regression
found and fixed during review)