static:: does not work on PHP 5.2

[vanderlee]

Hi,

I think this is my final pull request for now; the "static::CONST__" doesn't work in PHP 5.2 as I found out during some testing today. "self::CONST__", however, does work just fine. So I did a quick search and replace and here's the patch.

[SimonEast]

Hey, (sorry, wasn't sure where else I could post this general comment)

Appreciate the updates you guys have been making. We use Emogrifier pretty heavily in some of our apps, and keen to contribute if I can.

Anyone have ideas as to why some inlined styles contain spaces and line-returns and some don't? Sometimes the line-returns break things, so keep to clean them up if I can.

e.g...

<td style="font-family:HelveticaNeue, Arial, sans-serif;font-size:14px;vertical-align:top;border-collapse:collapse;"></td>
<th align="right" valign="top" style="font-family: HelveticaNeue, Arial, sans-serif;
            font-size: 14px;
            vertical-align: top;">Date</th> 

[nburka]

Hi SimonEast - just to make it clear, we use Emogrifier on a limited basis at the moment, so the development work here won't be very extensive. It was basically a quick project to clean up some of the code, PEAR package it, and add a couple features that we needed. That said, the updates from Martijn have been quite helpful (even if I can't review them as quickly as I'd like!) and we'd be happy to review and merge changes from any developers.

[vanderlee]

I've looked around on StackOverflow and settled on an "innerHTML" function (one of many similar ones).
This is probably a more reliable way of handling the problem.

[oliverklee]

Pelago (the original creator of Emogrifier) created an official repository of Emogrifier a few months ago:

https://github.com/jjriv/emogrifier

I propose filing the issue there (and providing pull requests for fixes).

Thanks!

Oliver

[nburka]

Sorry for the lack of movement on this clone of Emogrifier, but I've just been swamped with other work and haven't been able to dedicate any time to it. Glad Pelago has moved his version to GitHub though!