Skip to content

refactor: replace static manager singletons with Guice-injected services#17

Open
nbdSteve wants to merge 9 commits into
masterfrom
fm/armorplus-4e-registries-r9
Open

refactor: replace static manager singletons with Guice-injected services#17
nbdSteve wants to merge 9 commits into
masterfrom
fm/armorplus-4e-registries-r9

refactor: trim comments to terse WHY-only across the DI change

91f3a7d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 23, 2026 in 16s

Annotations

Check warning on line 16 in src/main/java/gg/steve/mc/ap/cmd/sub/GiveCmd.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 75 to 64, Complexity from 16 to 14, Nesting Level from 3 to 2, Number of Variables from 14 to 6.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ-Oq-CE3_y5QfimMvS3&open=AZ-Oq-CE3_y5QfimMvS3&pullRequest=17

Check failure on line 55 in src/main/java/gg/steve/mc/ap/player/PlayerArmorSetService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ-Oq-Cb3_y5QfimMvS4&open=AZ-Oq-Cb3_y5QfimMvS4&pullRequest=17