Skip to content

refactor(model): add pure-Java domain value types with TypedString/StringId typed IDs#13

Merged
nbdSteve merged 16 commits into
masterfrom
fm/armorplus-4b-domaintypes-d5
Jul 9, 2026
Merged

refactor(model): add pure-Java domain value types with TypedString/StringId typed IDs#13
nbdSteve merged 16 commits into
masterfrom
fm/armorplus-4b-domaintypes-d5

no-mistakes(lint): Fixed deprecated Validate.notNull; no remaining is…

1cc2522
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 9, 2026 in 18s

Annotations

Check warning on line 94 in src/test/java/gg/steve/mc/ap/model/notification/ArmorSetNotificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ9FlJvjO2M2KXt208HX&open=AZ9FlJvjO2M2KXt208HX&pullRequest=13

Check warning on line 5 in src/main/java/gg/steve/mc/ap/model/id/PlayerId.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Override the "equals" method in this class.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ9JPNL5Dsu0IuwnN0AE&open=AZ9JPNL5Dsu0IuwnN0AE&pullRequest=13

Check warning on line 47 in src/test/java/gg/steve/mc/ap/model/id/TypedStringTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ9JPNIzDsu0IuwnN0AC&open=AZ9JPNIzDsu0IuwnN0AC&pullRequest=13

Check warning on line 54 in src/test/java/gg/steve/mc/ap/model/id/TypedStringTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertEquals instead.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ9JPNIzDsu0IuwnN0AD&open=AZ9JPNIzDsu0IuwnN0AD&pullRequest=13

Check warning on line 105 in src/test/java/gg/steve/mc/ap/model/notification/ArmorSetNotificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ9FlJvjO2M2KXt208HY&open=AZ9FlJvjO2M2KXt208HY&pullRequest=13