test: add characterization tests for damage, wearer-tracking, warp, XP, potion, set-detection, and messaging logic#12
Merged
Conversation
…P, potion, set-detection, and messaging logic Regression tests pinning current behavior of Bukkit-integrated classes: - HandSetDataTest (15) - calculateFinalDamage pure math, hitWithoutSetBuff - BasicSetDataTest (12) - onHit/onDamage damage calc and knockback - SetPlayerManagerTest (9) - add/remove/isWearing state, getPiecesWearing - SetIsWearingTest (9) - Set.isWearingSet/verifyPiece via MockedConstruction<NBTItem> - SetStatusEffectsManagerTest (6) - potionCheck amplifier logic - WarpUtilTest (5) - isSafe three-block safety check - ExperienceSetDataTest (6) - onTargetDeath XP multiplier - MessageTypeTest + CommandDebugTest (10) - placeholder substitution Build: adds -Dnet.bytebuddy.experimental=true to surefire argLine (required for Mockito on JDK 25). Zero production code changes.
nbdSteve
force-pushed
the
fm/armorplus-4a-chartests-x2
branch
from
July 9, 2026 05:47
5e64ef5 to
daa946c
Compare
nbdSteve
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Adds 72 regression tests (8 new test classes) pinning current behavior of Bukkit-integrated classes via Mockito:
HandSetDataTestcalculateFinalDamagepure math,hitWithoutSetBuffBasicSetDataTestonHit/onDamagedamage calc and knockbackSetPlayerManagerTestgetPiecesWearingSetIsWearingTestSet.isWearingSet/verifyPieceviaMockedConstruction<NBTItem>SetStatusEffectsManagerTestpotionCheckamplifier comparison logicWarpUtilTestisSafethree-block safety checkExperienceSetDataTestonTargetDeathXP multiplier mathMessageTypeTest+CommandDebugTestAlso adds
-Dnet.bytebuddy.experimental=trueto surefire<argLine>- required for Mockito's ByteBuddy on JDK 25.Risk
Low. Zero production code changes (
src/main/**untouched). Only adds test files, updatesAGENTS.md, and modifiespom.xmlsurefire config.Testing
Existing 100% core gate on PlayerDirectionUtil, ColorUtil, Piece, SetType, SetDataType still passes.
Bytecode confirmed at Java 8 (major version 52).