Skip to content

fix(orch): preserve pending review-gated publish state#76

Merged
nathanwhit merged 1 commit into
mainfrom
codex/preserve-review-gated-publish-state
Jul 8, 2026
Merged

fix(orch): preserve pending review-gated publish state#76
nathanwhit merged 1 commit into
mainfrom
codex/preserve-review-gated-publish-state

Conversation

@nathanwhit

Copy link
Copy Markdown
Owner

Summary

Fixes two Orcha failure modes exposed by the review-gated publish incident:

  • Treat waiting_user objectives as non-terminal during workspace reclaim, so an unpublished worker checkout is not deleted while the manager is asking the operator about a publish blocker.
  • Mark one-shot tmux sessions that exit before an Orcha completion signal as failed, instead of reporting a clean success with no transcript/verdict.

Root Cause

The publish blocker was caused by broken Codex auth on the worker host, but Orcha hid that provider startup failure: the Codex reviewer tmux pane exited before any review/tool call and was recorded as succeeded, so the review gate only surfaced "ended without a verdict".

Then, because the manager opened an ask_user blocker, the objective moved to waiting_user. Reclaim treated every non-active objective as fully reclaimable and deleted the unpublished implementer checkout, even though the objective was not terminal.

Validation

  • go test ./...

@nathanwhit nathanwhit merged commit db4f330 into main Jul 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant