fix(orch): preserve pending review-gated publish state#76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two Orcha failure modes exposed by the review-gated publish incident:
waiting_userobjectives as non-terminal during workspace reclaim, so an unpublished worker checkout is not deleted while the manager is asking the operator about a publish blocker.Root Cause
The publish blocker was caused by broken Codex auth on the worker host, but Orcha hid that provider startup failure: the Codex reviewer tmux pane exited before any review/tool call and was recorded as
succeeded, so the review gate only surfaced "ended without a verdict".Then, because the manager opened an
ask_userblocker, the objective moved towaiting_user. Reclaim treated every non-activeobjective as fully reclaimable and deleted the unpublished implementer checkout, even though the objective was not terminal.Validation
go test ./...