Handle deploy lock ownership fallback when meza-ansible is missing#76
Open
arpitjain099 wants to merge 1 commit into
Open
Handle deploy lock ownership fallback when meza-ansible is missing#76arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps
meza deployfrom crashing on minimal hosts where themeza-ansibleaccount is not available yet.\n\nI kept the lock ownership behavior the same where possible, but made the fallback path resilient:\n- ifmeza-ansibleis missing, use the current user\n- keep group preference orderapache,www-data, thenwheel\n- if none of those groups exist, use the current process group\n\nI also added a regression test that covers the failing path from #74.\n\nTests run:\n-python3 -m unittest tests/unit/test_deploy_lock_fallback.py\n-python3 -m py_compile src/scripts/meza.py tests/unit/test_deploy_lock_fallback.py\n\nFixes #74