Rocket throat properties now printed even if there's no exit cone#91
Merged
Merged
Conversation
markleader
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #90 to ensure throat properties are printed on the legacy interface, even if no nozzle expansion points are requested. This aligns with CEA2 behavior.
Changes
Call mark_completed in Rocket.f90 when RocketSolver_solve_throat completes, duplicating the behavior of RocketSolver_solve_throat_frozen.
Testing
100% pass for legacy interface tests, ctest, pytest. Manually confirmed proper behavior for various combinations of IAC/FAC, eq /frz options (see attached files).
example8_chamberThroatOnly.inp.txt
example8_chamberThroatOnly.inp.txt
example8_chamberThroatOnly.out.txt
example8_chamberThroatOnly.out.txt
example8_frzchamberThroatOnly.inp.txt
example8_frzchamberThroatOnly.inp.txt
example8_frzchamberThroatOnly.out.txt
example8_frzchamberThroatOnly.out.txt
example9_chamberThroatOnly.inp.txt
example9_chamberThroatOnly.inp.txt
example9_chamberThroatOnly.out.txt
example9_chamberThroatOnly.out.txt
example9_frzchamberThroatOnly.inp.txt
example9_frzchamberThroatOnly.inp.txt
example9_frzchamberThroatOnly.out.txt
example9_frzchamberThroatOnly.out.txt
Compatibility / Numerical behavior