Skip to content

Ensure output text stating conductivity units is mW/cm-K on legacy interface when siunits is true#89

Merged
markleader merged 1 commit into
nasa:mainfrom
dfnca:fix/conductivityOutputFileUnits
Jun 16, 2026
Merged

Ensure output text stating conductivity units is mW/cm-K on legacy interface when siunits is true#89
markleader merged 1 commit into
nasa:mainfrom
dfnca:fix/conductivityOutputFileUnits

Conversation

@dfnca

@dfnca dfnca commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses Issue #88 wrong units described in output file for thermal conductivity in detonation, equilibrium, and rocket problems when siunits is true.

Changes

Added test for selected units system and appropriate text output depending on whether calories or SI units are selected.

Testing

  • ctest, legacy interface test, pytest all pass 100%. Example detonation, equilibrium and rocket example problems also verified.

Compatibility / Numerical behavior

  • [ X] No expected changes to numerical results
  • Expected changes (explain and provide validation)

@markleader markleader merged commit 6f79e37 into nasa:main Jun 16, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants