feature/implement lexer - part 1#2
Merged
Merged
Conversation
qwoprocks
reviewed
Jan 25, 2026
qwoprocks
reviewed
Jan 25, 2026
qwoprocks
reviewed
Jan 25, 2026
qwoprocks
reviewed
Jan 25, 2026
qwoprocks
requested changes
Jan 25, 2026
qwoprocks
left a comment
Member
There was a problem hiding this comment.
Took a quick look, I realized that we are missing one thing, which is that all formulas should start with =
qwoprocks
reviewed
Jan 25, 2026
qwoprocks
reviewed
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in the PR
Implement part 1 of lexer. From this paper, the items of table I in page 5 is added to
tests/lexer/README.md. A checklist is added to track what has been implemented and what is still remaining.tldr;
Tokens in the table implemented in the PR
TRUE | FALSE[0-9]+ .? [0-9]* (e [0-9]+)?" ([^ "] | "")* "#NULL! | #DIV/0! | #VALUE! | #NAME? | #NUM! | #N/A#REF!Tokens not in the table but used in BNF form implemented in the PR
How is it tested
For each entry, added unit tests in
tests/lexer/test_**.rs.