feature/Setup WASM#1
Merged
Merged
Conversation
Comment on lines
+43
to
+47
| # Rust toolchain (components are auto-installed via rust-toolchain.toml) | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh | ||
|
|
||
| # wasm-pack for WebAssembly builds | ||
| cargo install wasm-pack |
Member
There was a problem hiding this comment.
In line 99 of README, we have cargo install wasm-pack without rust toolchain installation instruction. Should we just remove the build instructions from README? Or let it reference to this file.
In both here and ci.yml, should we pin the rust toolchain and wasm pack versions...? (for repro)
Member
Author
There was a problem hiding this comment.
you're right, I think we can change ci.yml and install instructions to just use the Cargo.lock file actually
yarkhinephyo
approved these changes
Jan 18, 2026
yarkhinephyo
left a comment
yarkhinephyo
left a comment
Member
There was a problem hiding this comment.
some non-blocking comments, i think we should only have one installation instruction (or dockerfile) and the other markdown files just reference it
yarkhinephyo
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up the Rust → WASM framework, so that we can start writing the parser and testing it out.
Also adds CI that checks formatting, lints, tests, and builds