Skip to content

Draft: Add draw grid with clicks mode via context menu#2139

Draft
dominikatrojanowska wants to merge 2 commits into
developfrom
draw-grid-with-clicks
Draft

Draft: Add draw grid with clicks mode via context menu#2139
dominikatrojanowska wants to merge 2 commits into
developfrom
draw-grid-with-clicks

Conversation

@dominikatrojanowska

@dominikatrojanowska dominikatrojanowska commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds an option to draw large grid by enabling movement of motors while drawing and it's an outcome of the discussion.

This is an additional functionality I called "draw with clicks" since there are more clicks needed than in the default drawing (with drag).

  1. Toggle draw mode.
  2. Open context menu and choose Start Drawing.
  3. Without pressing the button move cursor wherever valid.
  4. Move motors with Sample alignment controls. The grid starting point sticks to its default position whereas ending point of the grid - to the last valid mouse position, thanks to this part.
  5. Hover over the Sample image and the ending position of the grid will be updated.
  6. Eventually, open the context menu one more time to either Save Grid or End drawing without saving.

Comment thread ui/src/components/SampleView/SampleImage.jsx Fixed
Comment thread ui/src/components/SampleView/SampleImage.jsx Fixed
Comment thread ui/src/components/SampleView/SampleImage.jsx Fixed
@dominikatrojanowska
dominikatrojanowska marked this pull request as draft July 1, 2026 15:24
@dominikatrojanowska dominikatrojanowska self-assigned this Jul 1, 2026
@mockoocy

mockoocy commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

How did you enable AI code review? Is there a button for that? :D
But sadly so far it said what eslint would say anyway :D

@dominikatrojanowska

Copy link
Copy Markdown
Contributor Author

@mockoocy I have no idea how it turned on... if I made it I was not aware

@walesch-yan

Copy link
Copy Markdown
Collaborator

How did you enable AI code review? Is there a button for that? :D But sadly so far it said what eslint would say anyway :D

It should be enabled repository-wide. You should normally see a group of checks called Code - CL. However I think it only triggers when you make a PR from another branch of this repository, not when you trigger the PR from a fork (I believe, you would need to set some specific configurations in the fork then)

@mockoocy

mockoocy commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Oh, I usually use a fork, that explains a lot then, thank you!

@marcus-oscarsson

Copy link
Copy Markdown
Member

Yes its repository wide and does a quite good job actually, its enabled repository wide. But It wont have access to comment on your branch

@dominikatrojanowska
dominikatrojanowska force-pushed the draw-grid-with-clicks branch 3 times, most recently from 66fae96 to f956bb7 Compare July 7, 2026 12:46
Introduces a two-step grid drawing mode: Start drawing + Save Grid / End drawing
context menu options. This allows to move motors between steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants