Model Dutch Blitz mechanics in Race Outlook#269
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8a7b05839
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let winnerBlitzed = false; | ||
|
|
||
| for (let r = 0; r < MAX_FUTURE_ROUNDS; r++) { | ||
| const outcomes = stats.map((s) => sampleRoundOutcome(s, rng)); |
There was a problem hiding this comment.
Ensure simulated rounds include a blitzer
When each player's mechanics are sampled independently here, a future round can have zero outcomes[i].blitzed (for four players with 20% blitz rates this happens about 41% of the time). The app's scoring rules reject such rounds via validateGameRules in src/lib/validation/gameRules.ts, which requires at least one blitzPileRemaining === 0, so the mechanics forecast spends many simulations on impossible non-blitz rounds and skews next-round danger/blitz-out odds; resample or otherwise condition the round on at least one blitzer.
Useful? React with 👍 / 👎.
28cf940 to
6a5ad4b
Compare
9009a20 to
c36f3bf
Compare
|
Closed as superseded by merged integration PR #270. |
Summary
Blitz-out pathand20+ pt swingreadouts in Race OutlookStack notes
mwickett/history-blended-race-outlook)Claude review
GAME_RULES.MIN_CARDS_FOR_BLITZminimum whenever a simulated round is a blitzVerification
npm run lintnpm testRESEND_API_KEY=re_dummy npx next buildIntegration/testing PR: #270 contains the full stack for end-to-end testing.